Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a number of window management features
Tested on Mac OS Ventura 13.6.6 / Intel and Gentoo Linux 6.7.6 w/ Openbox WM. Attempted to test on Wayland, but ran into wgpu crashes with the OpenGL back-end (unrelated to the patches) and I don't have the DRM back-end built locally.
Caveats/questions:
winit
to read or set window properties which can returnNotSupportedError
on some platforms (mainly Android and Wayland). In cases where we can return something synchonously we returnNone
or a reasonable default (for example, scaling is always1.0
on Android). Should we instead:Option<Box<dyn FnOnce(NotSupportedError)>>
to get notified of the error? (given there's little they can do about it, this seems a bit much)